Skip to content

Commit 6103618

Browse files
committed
Remove unnecessary optimization FIXME
As the comment suggests, the return value of frameless calls is rarely not used. When it isn't used (and isn't refcounted) the FREE is already elided by the optimizer. Closes GH-20819
1 parent 8f8d2a4 commit 6103618

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

Zend/zend_compile.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -816,8 +816,6 @@ static void zend_do_free(znode *op1) /* {{{ */
816816
} else {
817817
/* Frameless calls usually use the return value, so always emit a free. This should be
818818
* faster than checking RETURN_VALUE_USED inside the handler. */
819-
// FIXME: We may actually look at the function signature to determine whether a free
820-
// is necessary.
821819
zend_emit_op(NULL, ZEND_FREE, op1, NULL);
822820
}
823821
} else {

0 commit comments

Comments
 (0)