Mark Phar::buildFromIterator() base directory argument as a path

ndossche · ndossche · commit 64f00fe3b36d · 2026-01-10T10:52:31.000+01:00
This is like buildFromDirectory() which does it right.
diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c
@@ -1828,7 +1828,7 @@ PHP_METHOD(Phar, buildFromIterator)
 	zend_string *base = ZSTR_EMPTY_ALLOC();
 	struct _phar_t pass;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS(), "O|S!", &obj, zend_ce_traversable, &base) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS(), "O|P!", &obj, zend_ce_traversable, &base) == FAILURE) {
 		RETURN_THROWS();
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1828,7 +1828,7 @@ PHP_METHOD(Phar, buildFromIterator)`
`1828`	`1828`	`zend_string *base = ZSTR_EMPTY_ALLOC();`
`1829`	`1829`	`struct _phar_t pass;`
`1830`	`1830`
`1831`		`- if (zend_parse_parameters(ZEND_NUM_ARGS(), "O\|S!", &obj, zend_ce_traversable, &base) == FAILURE) {`
	`1831`	`+ if (zend_parse_parameters(ZEND_NUM_ARGS(), "O\|P!", &obj, zend_ce_traversable, &base) == FAILURE) {`
`1832`	`1832`	`RETURN_THROWS();`
`1833`	`1833`	`}`
`1834`	`1834`