Skip to content

Commit 65c7c33

Browse files
committed
Don't run windows with asan in push
This is slower than I anticipated
1 parent 85efad8 commit 65c7c33

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

.github/nightly_matrix.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,12 @@ function select_jobs($trigger, $labels, $php_version, $ref, $all_variations) {
124124
$jobs['PECL'] = true;
125125
}
126126
if ($all_jobs || !$no_jobs || $test_windows) {
127-
$windows_jobs = ['include' => [['asan' => true, 'opcache' => true, 'x64' => true, 'zts' => true]]];
128-
if ($all_variations) {
129-
$windows_jobs['include'][] = ['asan' => false, 'opcache' => false, 'x64' => false, 'zts' => false];
130-
}
131-
$jobs['WINDOWS']['matrix'] = $windows_jobs;
127+
$jobs['WINDOWS']['matrix'] = $all_variations
128+
? ['include' => [
129+
['asan' => true, 'opcache' => true, 'x64' => true, 'zts' => true],
130+
['asan' => false, 'opcache' => false, 'x64' => false, 'zts' => false],
131+
]]
132+
: ['include' => [['asan' => false, 'opcache' => true, 'x64' => true, 'zts' => true]]];
132133
$jobs['WINDOWS']['config'] = version_compare($php_version, '8.4', '>=')
133134
? ['vs_crt_version' => 'vs17']
134135
: ['vs_crt_version' => 'vs16'];

0 commit comments

Comments
 (0)