reflection: Check against the known string in is_closure_invoke() (#21402)

TimWolla · web-flow · commit 6e664a04cb8f · 2026-03-10T20:06:34.000+01:00
This can likely succeed by just comparing pointers in a majority of cases.
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
@@ -191,7 +191,7 @@ static zend_always_inline uint32_t prop_get_flags(const property_reference *ref)
 
 static inline bool is_closure_invoke(const zend_class_entry *ce, const zend_string *lcname) {
 	return ce == zend_ce_closure
-		&& zend_string_equals_literal(lcname, ZEND_INVOKE_FUNC_NAME);
+		&& zend_string_equals(lcname, ZSTR_KNOWN(ZEND_STR_MAGIC_INVOKE));
 }
 
 static zend_function *_copy_function(zend_function *fptr) /* {{{ */

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ static zend_always_inline uint32_t prop_get_flags(const property_reference *ref)`
`191`	`191`
`192`	`192`	`static inline bool is_closure_invoke(const zend_class_entry ce, const zend_string lcname) {`
`193`	`193`	`return ce == zend_ce_closure`
`194`		`- && zend_string_equals_literal(lcname, ZEND_INVOKE_FUNC_NAME);`
	`194`	`+ && zend_string_equals(lcname, ZSTR_KNOWN(ZEND_STR_MAGIC_INVOKE));`
`195`	`195`	`}`
`196`	`196`
`197`	`197`	`static zend_function _copy_function(zend_function fptr) /* {{{ */`