Skip to content

Commit 6f1beed

Browse files
committed
[skip ci] Fix CXXFLAGS for type verification build
The attempted fix in ba32d70 was incorrect as the flags are later overwritten with -D_GLIBCXX_ASSERTIONS. Closes GH-22639
1 parent ee0f2b9 commit 6f1beed

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/test-suite.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,10 @@ jobs:
166166
with:
167167
configurationParameters: >-
168168
${{ matrix.asan && 'CFLAGS="-fsanitize=undefined,address -DZEND_TRACK_ARENA_ALLOC" LDFLAGS="-fsanitize=undefined,address"' || '' }}
169-
${{ matrix.variation && 'CFLAGS="-DZEND_RC_DEBUG=1 -DPROFITABILITY_CHECKS=0 -DZEND_VERIFY_FUNC_INFO=1 -DZEND_VERIFY_TYPE_INFERENCE" CXXFLAGS="-DZEND_VERIFY_TYPE_INFERENCE"' || '' }}
169+
${{ matrix.variation && 'CFLAGS="-DZEND_RC_DEBUG=1 -DPROFITABILITY_CHECKS=0 -DZEND_VERIFY_FUNC_INFO=1 -DZEND_VERIFY_TYPE_INFERENCE"' || '' }}
170170
${{ (matrix.variation && fromJson(inputs.branch).jobs.LINUX_X64.config.variation_enable_zend_max_execution_timers) && '--enable-zend-max-execution-timers' || '' }}
171171
--${{ matrix.debug && 'enable' || 'disable' }}-debug
172-
${{ matrix.debug && 'CXXFLAGS="-D_GLIBCXX_ASSERTIONS"' || '' }}
172+
${{ (matrix.variation || matrix.debug) && format('CXXFLAGS="{0} {1}"', matrix.variation && '-DZEND_VERIFY_TYPE_INFERENCE' || '', matrix.debug && '-D_GLIBCXX_ASSERTIONS' || '') || '' }}
173173
--${{ matrix.zts && 'enable' || 'disable' }}-zts
174174
asan: ${{ matrix.asan && 'true' || 'false' }}
175175
skipSlow: ${{ (matrix.asan && !inputs.all_variations) && 'true' || 'false' }}

0 commit comments

Comments
 (0)