ext/session: no need to free a known zend_string

Girgias · Girgias · commit 713fbeda97bd · 2026-02-05T13:01:38.000Z
diff --git a/ext/session/session.c b/ext/session/session.c
@@ -2065,14 +2065,12 @@ static bool can_session_handler_be_changed(void) {
 }
 
 static inline void set_user_save_handler_ini(void) {
-	zend_string *ini_name, *ini_val;
+	/* const */ zend_string *ini_val = ZSTR_KNOWN(ZEND_STR_USER);
+	zend_string *ini_name = ZSTR_INIT_LITERAL("session.save_handler", false);
 
-	ini_name = ZSTR_INIT_LITERAL("session.save_handler", false);
-	ini_val = ZSTR_KNOWN(ZEND_STR_USER);
 	PS(set_handler) = true;
 	zend_alter_ini_entry(ini_name, ini_val, PHP_INI_USER, PHP_INI_STAGE_RUNTIME);
 	PS(set_handler) = false;
-	zend_string_release_ex(ini_val, false);
 	zend_string_release_ex(ini_name, false);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2065,14 +2065,12 @@ static bool can_session_handler_be_changed(void) {`
`2065`	`2065`	`}`
`2066`	`2066`
`2067`	`2067`	`static inline void set_user_save_handler_ini(void) {`
`2068`		`- zend_string ini_name, ini_val;`
	`2068`	`+ /* const / zend_string ini_val = ZSTR_KNOWN(ZEND_STR_USER);`
	`2069`	`+ zend_string *ini_name = ZSTR_INIT_LITERAL("session.save_handler", false);`
`2069`	`2070`
`2070`		`- ini_name = ZSTR_INIT_LITERAL("session.save_handler", false);`
`2071`		`- ini_val = ZSTR_KNOWN(ZEND_STR_USER);`
`2072`	`2071`	`PS(set_handler) = true;`
`2073`	`2072`	`zend_alter_ini_entry(ini_name, ini_val, PHP_INI_USER, PHP_INI_STAGE_RUNTIME);`
`2074`	`2073`	`PS(set_handler) = false;`
`2075`		`- zend_string_release_ex(ini_val, false);`
`2076`	`2074`	`zend_string_release_ex(ini_name, false);`
`2077`	`2075`	`}`
`2078`	`2076`