openssl: Fix missing error propagation in openssl_x509_export() (#21375)

ndossche · web-flow · commit 7831244633d0 · 2026-04-03T22:43:31.000+02:00
The file writes can have failed, but this error isn't visible for the application,
fix it by propagating the error properly.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -1869,8 +1869,7 @@ PHP_FUNCTION(openssl_x509_export)
 	}
 	if (!notext && !X509_print(bio_out, cert)) {
 		php_openssl_store_errors();
-	}
-	if (PEM_write_bio_X509(bio_out, cert)) {
+	} else if (PEM_write_bio_X509(bio_out, cert)) {
 		BUF_MEM *bio_buf;
 
 		BIO_get_mem_ptr(bio_out, &bio_buf);

Original file line number	Diff line number	Diff line change
`@@ -1869,8 +1869,7 @@ PHP_FUNCTION(openssl_x509_export)`
`1869`	`1869`	`}`
`1870`	`1870`	`if (!notext && !X509_print(bio_out, cert)) {`
`1871`	`1871`	`php_openssl_store_errors();`
`1872`		`- }`
`1873`		`- if (PEM_write_bio_X509(bio_out, cert)) {`
	`1872`	`+ } else if (PEM_write_bio_X509(bio_out, cert)) {`
`1874`	`1873`	`BUF_MEM *bio_buf;`
`1875`	`1874`
`1876`	`1875`	`BIO_get_mem_ptr(bio_out, &bio_buf);`