@@ -6,14 +6,14 @@ conventions are enumerated in this document.
66* The last error is always stored globally.
77
88The global error code can be obtained in userland with ` intl_get_error_code() ` .
9- This is a ` U_* ` error code defined by ICU, but it does not have necessarily to
10- be returned obtained after a call to an ICU function. That is to say, the
9+ This is a ` U_* ` error code defined by ICU, but it is not necessarily obtained
10+ from a call to an ICU function. That is to say, the
1111internal PHP wrapper functions can set these error codes when appropriate. For
1212instance, in response to bad arguments (e.g. ` zend_parse_parameters() ` failure),
1313the PHP wrapper function should set the global error code to
14- ` U_ILLEGAL_ARGUMENT_ERROR ` ) .
14+ ` U_ILLEGAL_ARGUMENT_ERROR ` .
1515
16- The error code (an integer) can be converter to the corresponding enum name
16+ The error code (an integer) can be converted to the corresponding enum name
1717string in userland with ` intl_error_name() ` .
1818
1919The associated message can be obtained with ` intl_get_error_message() ` . This is
@@ -60,23 +60,23 @@ void intl_errors_set(intl_error* err, UErrorCode code, char* msg, int copyMsg);
6060```
6161
6262by passing a pointer to the object's `intl_error` as the first parameter.
63- Node the extra `s` in the functions' names (`errors`, not `error`).
63+ Note the extra `s` in the functions' names (`errors`, not `error`).
6464
6565Static methods should only set the global error.
6666
6767* Intl classes that can be instantiated should provide `::getErrorCode()` and
6868 `getErrorMessage()` methods.
6969
7070These methods are used to retrieve the error codes stored in the object's
71- private `intl_error` structured and mirror the global `intl_get_error_code()`
71+ private `intl_error` structure and mirror the global `intl_get_error_code()`
7272and `intl_get_error_message()`.
7373
7474* Intl methods and functions should return `FALSE` on error (even argument
7575 parsing errors), not `NULL`. Constructors and factory methods are the
7676 exception; these should return `NULL`, not `FALSE`.
7777
78- Note that constructors in Intl generally (always?) don't throws exceptions. They
79- instead destroy the object to that the result of new `IntlClass()` can be
78+ Note that constructors in Intl generally (always?) do not throw exceptions. They
79+ instead destroy the object so that the result of new `IntlClass()` can be
8080`NULL`. This may be surprising.
8181
8282* Intl functions and methods should reset the global error before doing anything
0 commit comments