Skip to content

Commit 86293d4

Browse files
committed
Add length check, as it turns out the non _ex version returns an empty string rather than NULL in certain cases
1 parent bcef0ec commit 86293d4

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

ext/standard/mail.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ PHP_FUNCTION(mail)
337337
}
338338

339339
zend_string *force_extra_parameters = zend_ini_str_literal("mail.force_extra_parameters");
340-
if (force_extra_parameters) {
340+
if (force_extra_parameters && ZSTR_LEN(force_extra_parameters) > 0) {
341341
extra_cmd = php_escape_shell_cmd(force_extra_parameters);
342342
} else if (extra_cmd) {
343343
extra_cmd = php_escape_shell_cmd(extra_cmd);

ext/standard/tests/mail/mail_basic2.phpt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,17 @@ $message = 'A Message';
2020
$additional_headers = 'KHeaders';
2121
$additional_parameters = "-n";
2222
$outFile = "/tmp/php_test_mailBasic2.out";
23-
@unlink($outFile);
2423

2524
echo "-- extra parameters --\n";
2625
// Calling mail() with all possible arguments
2726
var_dump( mail($to, $subject, $message, $additional_headers, $additional_parameters) );
2827

2928
echo file_get_contents($outFile);
30-
unlink($outFile);
29+
30+
?>
31+
--CLEAN--
32+
<?php
33+
@unlink("/tmp/php_test_mailBasic2.out");
3134
?>
3235
--EXPECTF--
3336
*** Testing mail() : basic functionality ***

0 commit comments

Comments
 (0)