fix: opcache static cache hooks

Author: zeriyoshi

Zend/tests/static_cache_hook_safety.phpt

@@ -0,0 +1,50 @@
+--TEST--
+OPcache static cache init hooks are request guarded
+--SKIPIF--
+<?php
+$zendDir = dirname(__DIR__);
+foreach (['zend_object_handlers.c', 'zend_vm_def.h', 'zend_vm_execute.h'] as $file) {
+    if (!is_file($zendDir . '/' . $file)) {
+        die('skip source tree required');
+    }
+}
+?>
+--FILE--
+<?php
+
+function requireGuardedHook(string $source, string $file, string $hook, int $minimum): void
+{
+    $unguarded = 'UNEXPECTED(' . $hook . ' != NULL)';
+    if (str_contains($source, $unguarded)) {
+        throw new RuntimeException($file . ' calls ' . $hook . ' without the request guard');
+    }
+
+    $pattern = '/EG\\(static_cache_class_access_active\\) &&\\s+' . preg_quote($hook, '/') . ' != NULL\\)\\s*\\)?\\s*\\{\\s+' . preg_quote($hook, '/') . '\\(/s';
+    if (preg_match_all($pattern, $source) < $minimum) {
+        throw new RuntimeException($file . ' is missing the guarded ' . $hook . ' calls');
+    }
+}
+
+$zendDir = dirname(__DIR__);
+
+requireGuardedHook(
+    file_get_contents($zendDir . '/zend_object_handlers.c'),
+    'zend_object_handlers.c',
+    'zend_class_init_statics_hook',
+    1
+);
+
+foreach (['zend_vm_def.h' => 2, 'zend_vm_execute.h' => 4] as $file => $minimum) {
+    requireGuardedHook(
+        file_get_contents($zendDir . '/' . $file),
+        $file,
+        'zend_function_init_statics_hook',
+        $minimum
+    );
+}
+
+echo "OK\n";
+
+?>
+--EXPECT--
+OK

Zend/zend_globals.h

@@ -269,7 +269,7 @@ struct _zend_executor_globals {
 
 	bool active;
 
-	bool static_cache_class_access_active;		/* fast guard for zend_class_static_access_hook */
+	bool static_cache_class_access_active;		/* fast guard for OPcache static cache hooks */
 	bool tracked_mutation_hooks_active;			/* fast guard for tracked array/object mutation hooks */
 
 	uint8_t flags;

Zend/zend_object_handlers.c

@@ -2095,7 +2095,9 @@ ZEND_API void zend_class_init_statics(zend_class_entry *class_type) /* {{{ */
 			}
 		}
 
-		if (UNEXPECTED(zend_class_init_statics_hook != NULL)) {
+		if (UNEXPECTED(EG(static_cache_class_access_active) &&
+			zend_class_init_statics_hook != NULL)
+		) {
 			zend_class_init_statics_hook(class_type);
 		}
 	}

Zend/zend_vm_def.h

@@ -9267,7 +9267,9 @@ ZEND_VM_HANDLER(183, ZEND_BIND_STATIC, CV, ANY, REF)
 
 	SAVE_OPLINE();
 
-	if (UNEXPECTED(zend_function_init_statics_hook != NULL)) {
+	if (UNEXPECTED(EG(static_cache_class_access_active) &&
+		zend_function_init_statics_hook != NULL)
+	) {
 		zend_function_init_statics_hook(execute_data);
 	}
 
@@ -9322,7 +9324,9 @@ ZEND_VM_HANDLER(203, ZEND_BIND_INIT_STATIC_OR_JMP, CV, JMP_ADDR)
 
 	variable_ptr = GET_OP1_ZVAL_PTR_PTR_UNDEF(BP_VAR_W);
 
-	if (UNEXPECTED(zend_function_init_statics_hook != NULL)) {
+	if (UNEXPECTED(EG(static_cache_class_access_active) &&
+		zend_function_init_statics_hook != NULL)
+	) {
 		zend_function_init_statics_hook(execute_data);
 	}