Revert IV length as ValueError

Girgias · Girgias · commit c9fb022d50c7 · 2020-08-11T00:32:32.000+02:00
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -6748,8 +6748,8 @@ PHP_FUNCTION(openssl_open)
 			RETURN_THROWS();
 		}
 		if ((size_t)cipher_iv_len != iv_len) {
-			zend_argument_value_error(6, "length is invalid");
-			RETURN_THROWS();
+			php_error_docref(NULL, E_WARNING, "IV length is invalid");
+			RETURN_FALSE;
 		}
 		iv_buf = (unsigned char *)iv;
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -6748,8 +6748,8 @@ PHP_FUNCTION(openssl_open)`
`6748`	`6748`	`RETURN_THROWS();`
`6749`	`6749`	`}`
`6750`	`6750`	`if ((size_t)cipher_iv_len != iv_len) {`
`6751`		`- zend_argument_value_error(6, "length is invalid");`
`6752`		`- RETURN_THROWS();`
	`6751`	`+ php_error_docref(NULL, E_WARNING, "IV length is invalid");`
	`6752`	`+ RETURN_FALSE;`
`6753`	`6753`	`}`
`6754`	`6754`	`iv_buf = (unsigned char *)iv;`
`6755`	`6755`	`} else {`