openssl: Fix stack leak in php_openssl_load_all_certs_from_file()

ndossche · ndossche · commit d7551300e2c8 · 2026-03-12T08:24:01.000+01:00
The previous code only freed the stack but not its contents. As reported by 4b9e80e#r179336568
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -2330,7 +2330,7 @@ static STACK_OF(X509) *php_openssl_load_all_certs_from_file(
 	ret = stack;
 end:
 	BIO_free(in);
-	sk_X509_INFO_free(sk);
+	sk_X509_INFO_pop_free(sk, X509_INFO_free);
 
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -2330,7 +2330,7 @@ static STACK_OF(X509) *php_openssl_load_all_certs_from_file(`
`2330`	`2330`	`ret = stack;`
`2331`	`2331`	`end:`
`2332`	`2332`	`BIO_free(in);`
`2333`		`- sk_X509_INFO_free(sk);`
	`2333`	`+ sk_X509_INFO_pop_free(sk, X509_INFO_free);`
`2334`	`2334`
`2335`	`2335`	`return ret;`
`2336`	`2336`	`}`