Skip to content

Commit e37da49

Browse files
committed
Add new literal ini API and remove the INI_*() macros
1 parent 2eb0a1f commit e37da49

File tree

21 files changed

+61
-62
lines changed

21 files changed

+61
-62
lines changed

Zend/zend_fibers.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,9 +572,9 @@ static ZEND_STACK_ALIGNED void zend_fiber_execute(zend_fiber_transfer *transfer)
572572
zend_fiber *fiber = EG(active_fiber);
573573

574574
/* Determine the current error_reporting ini setting. */
575-
zend_long error_reporting = INI_INT("error_reporting");
575+
zend_long error_reporting = zend_ini_long_literal("error_reporting");
576576
/* If error_reporting is 0 and not explicitly set to 0, zend_ini_str returns a null pointer. */
577-
if (!error_reporting && !zend_ini_str(ZEND_STRL("error_reporting"), false)) {
577+
if (!error_reporting && !zend_ini_str_literal("error_reporting")) {
578578
error_reporting = E_ALL;
579579
}
580580

Zend/zend_ini.h

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,17 @@ ZEND_API zend_string *zend_ini_str_ex(const char *name, size_t name_length, bool
9595
ZEND_API zend_string *zend_ini_get_value(zend_string *name);
9696
ZEND_API bool zend_ini_parse_bool(const zend_string *str);
9797

98+
#define zend_ini_bool_literal(name) zend_ini_parse_bool(zend_ini_str((name), sizeof("" name) - 1, false))
99+
#define zend_ini_long_literal(name) zend_ini_long((name), sizeof("" name) - 1, false)
100+
#define zend_ini_double_literal(name) zend_ini_double((name), sizeof("" name) - 1, false)
101+
#define zend_ini_str_literal(name) zend_ini_str((name), sizeof("" name) - 1, false)
102+
#define zend_ini_string_literal(name) zend_ini_string((name), sizeof("" name) - 1, false)
103+
104+
#define INI_ORIG_INT(name) zend_ini_long((name), strlen(name), 1)
105+
#define INI_ORIG_FLT(name) zend_ini_double((name), strlen(name), 1)
106+
#define INI_ORIG_STR(name) zend_ini_string((name), strlen(name), 1)
107+
#define INI_ORIG_BOOL(name) zend_ini_parse_bool(zend_ini_str((name), strlen(name), true))
108+
98109
/**
99110
* Parses an ini quantity
100111
*
@@ -191,16 +202,6 @@ END_EXTERN_C()
191202
ZEND_INI_ENTRY3_EX(name, default_value, modifiable, on_modify, (void *) XtOffsetOf(struct_type, property_name), (void *) &struct_ptr, NULL, zend_ini_boolean_displayer_cb)
192203
#endif
193204

194-
#define INI_INT(name) zend_ini_long((name), strlen(name), 0)
195-
#define INI_FLT(name) zend_ini_double((name), strlen(name), 0)
196-
#define INI_STR(name) zend_ini_string_ex((name), strlen(name), 0, NULL)
197-
#define INI_BOOL(name) zend_ini_parse_bool(zend_ini_str((name), strlen(name), false))
198-
199-
#define INI_ORIG_INT(name) zend_ini_long((name), strlen(name), 1)
200-
#define INI_ORIG_FLT(name) zend_ini_double((name), strlen(name), 1)
201-
#define INI_ORIG_STR(name) zend_ini_string((name), strlen(name), 1)
202-
#define INI_ORIG_BOOL(name) zend_ini_parse_bool(zend_ini_str((name), strlen(name), true))
203-
204205
#define REGISTER_INI_ENTRIES() zend_register_ini_entries_ex(ini_entries, module_number, type)
205206
#define UNREGISTER_INI_ENTRIES() zend_unregister_ini_entries_ex(module_number, type)
206207
#define DISPLAY_INI_ENTRIES() display_ini_entries(zend_module)

Zend/zend_multibyte.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ ZEND_API zend_result zend_multibyte_set_functions(const zend_multibyte_functions
114114
* populated, we need to reinitialize script_encoding here.
115115
*/
116116
{
117-
const char *value = zend_ini_string("zend.script_encoding", sizeof("zend.script_encoding") - 1, 0);
118-
zend_multibyte_set_script_encoding_by_string(value, strlen(value));
117+
const zend_string *value = zend_ini_str_literal("zend.script_encoding");
118+
zend_multibyte_set_script_encoding_by_string(ZSTR_VAL(value), ZSTR_LEN(value));
119119
}
120120
return SUCCESS;
121121
}

ext/com_dotnet/com_dotnet.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ static HRESULT dotnet_bind_runtime(LPVOID FAR *ppv)
139139
return S_FALSE;
140140
}
141141

142-
const zend_string *version = zend_ini_str(ZEND_STRL("com.dotnet_version"), false);
142+
const zend_string *version = zend_ini_str_literal("com.dotnet_version");
143143
if (version == NULL || ZSTR_LEN(version) == 0) {
144144
oleversion = NULL;
145145
} else {

ext/curl/interface.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1112,9 +1112,9 @@ static void _php_curl_set_default_options(php_curl *ch)
11121112
curl_easy_setopt(ch->cp, CURLOPT_DNS_CACHE_TIMEOUT, 120L);
11131113
curl_easy_setopt(ch->cp, CURLOPT_MAXREDIRS, 20L); /* prevent infinite redirects */
11141114

1115-
const char* cainfo = INI_STR("openssl.cafile");
1115+
const char* cainfo = zend_ini_string_literal("openssl.cafile");
11161116
if (!(cainfo && cainfo[0] != '\0')) {
1117-
cainfo = INI_STR("curl.cainfo");
1117+
cainfo = zend_ini_string_literal("curl.cainfo");
11181118
}
11191119
if (cainfo && cainfo[0] != '\0') {
11201120
curl_easy_setopt(ch->cp, CURLOPT_CAINFO, cainfo);

ext/date/php_date.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5480,18 +5480,18 @@ static void php_do_date_sunrise_sunset(INTERNAL_FUNCTION_PARAMETERS, bool calc_s
54805480
ZEND_PARSE_PARAMETERS_END();
54815481

54825482
if (latitude_is_null) {
5483-
latitude = INI_FLT("date.default_latitude");
5483+
latitude = zend_ini_double_literal("date.default_latitude");
54845484
}
54855485

54865486
if (longitude_is_null) {
5487-
longitude = INI_FLT("date.default_longitude");
5487+
longitude = zend_ini_double_literal("date.default_longitude");
54885488
}
54895489

54905490
if (zenith_is_null) {
54915491
if (calc_sunset) {
5492-
zenith = INI_FLT("date.sunset_zenith");
5492+
zenith = zend_ini_double_literal("date.sunset_zenith");
54935493
} else {
5494-
zenith = INI_FLT("date.sunrise_zenith");
5494+
zenith = zend_ini_double_literal("date.sunrise_zenith");
54955495
}
54965496
}
54975497

ext/gd/gd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1599,7 +1599,7 @@ static void _php_image_create_from(INTERNAL_FUNCTION_PARAMETERS, int image_type,
15991599

16001600
#ifdef HAVE_GD_JPG
16011601
case PHP_GDIMG_TYPE_JPG:
1602-
ignore_warning = INI_INT("gd.jpeg_ignore_warning");
1602+
ignore_warning = zend_ini_bool_literal("gd.jpeg_ignore_warning");
16031603
im = gdImageCreateFromJpegEx(fp, ignore_warning);
16041604
break;
16051605
#endif

ext/openssl/openssl_backend_common.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -504,10 +504,8 @@ void php_openssl_set_cert_locations(zval *return_value)
504504
add_assoc_string(return_value, "default_cert_dir_env", (char *) X509_get_default_cert_dir_env());
505505
add_assoc_string(return_value, "default_private_dir", (char *) X509_get_default_private_dir());
506506
add_assoc_string(return_value, "default_default_cert_area", (char *) X509_get_default_cert_area());
507-
add_assoc_str(return_value, "ini_cafile",
508-
zend_string_copy(zend_ini_str(ZEND_STRL("openssl.cafile"), false)));
509-
add_assoc_str(return_value, "ini_capath",
510-
zend_string_copy(zend_ini_str(ZEND_STRL("openssl.capath"), false)));
507+
add_assoc_str(return_value, "ini_cafile", zend_string_copy(zend_ini_str_literal("openssl.cafile")));
508+
add_assoc_str(return_value, "ini_capath", zend_string_copy(zend_ini_str_literal("openssl.capath")));
511509
}
512510

513511
X509 *php_openssl_x509_from_str(

ext/openssl/xp_ssl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,7 @@ static zend_result php_openssl_enable_peer_verification(SSL_CTX *ctx, php_stream
888888
GET_VER_OPT_STRING("capath", capath);
889889

890890
if (cafile == NULL) {
891-
const zend_string *cafile_str = zend_ini_str(ZEND_STRL("openssl.cafile"), false);
891+
const zend_string *cafile_str = zend_ini_str_literal("openssl.cafile");
892892
cafile = ZSTR_LEN(cafile_str) ? ZSTR_VAL(cafile_str) : NULL;
893893
} else if (!sslsock->is_client) {
894894
/* Servers need to load and assign CA names from the cafile */
@@ -902,7 +902,7 @@ static zend_result php_openssl_enable_peer_verification(SSL_CTX *ctx, php_stream
902902
}
903903

904904
if (capath == NULL) {
905-
const zend_string *capath_str = zend_ini_str(ZEND_STRL("openssl.capath"), false);
905+
const zend_string *capath_str = zend_ini_str_literal("openssl.capath");
906906
capath = ZSTR_LEN(capath_str) ? ZSTR_VAL(capath_str) : NULL;
907907
}
908908

ext/session/session.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1637,15 +1637,15 @@ PHPAPI zend_result php_session_start(void)
16371637
break;
16381638

16391639
case php_session_disabled: {
1640-
const char *value = zend_ini_string(ZEND_STRL("session.save_handler"), false);
1640+
const char *value = zend_ini_string_literal("session.save_handler");
16411641
if (!PS(mod) && value) {
16421642
PS(mod) = _php_find_ps_module(value);
16431643
if (!PS(mod)) {
16441644
php_error_docref(NULL, E_WARNING, "Cannot find session save handler \"%s\" - session startup failed", value);
16451645
return FAILURE;
16461646
}
16471647
}
1648-
value = zend_ini_string(ZEND_STRL("session.serialize_handler"), false);
1648+
value = zend_ini_string_literal("session.serialize_handler");
16491649
if (!PS(serializer) && value) {
16501650
PS(serializer) = _php_find_ps_serializer(value);
16511651
if (!PS(serializer)) {
@@ -2768,14 +2768,14 @@ static zend_result php_rinit_session(bool auto_start)
27682768

27692769
PS(mod) = NULL;
27702770
{
2771-
const char *value = zend_ini_string(ZEND_STRL("session.save_handler"), false);
2771+
const char *value = zend_ini_string_literal("session.save_handler");
27722772
if (value) {
27732773
PS(mod) = _php_find_ps_module(value);
27742774
}
27752775
}
27762776

27772777
if (PS(serializer) == NULL) {
2778-
const char *value = zend_ini_string(ZEND_STRL("session.serialize_handler"), false);
2778+
const char *value = zend_ini_string_literal("session.serialize_handler");
27792779
if (value) {
27802780
PS(serializer) = _php_find_ps_serializer(value);
27812781
}

0 commit comments

Comments
 (0)