pgsql ext: pg_query_params/pg_send_query_params false constant handling proposal.

Author: devnexen

ext/pgsql/pgsql.c

@@ -1120,7 +1120,17 @@ PHP_FUNCTION(pg_query_params)
 			if (Z_TYPE_P(tmp) == IS_NULL) {
 				params[i] = NULL;
 			} else {
-				zend_string *param_str = zval_try_get_string(tmp);
+				zend_string *param_str;
+				/**
+				 * zval_try_get_string returns an empty zend_string
+				 * for false which is correct in general
+				 * but not adequate for bool values in the db
+				 */
+				if (Z_TYPE_P(tmp) == IS_FALSE) {
+					param_str = ZSTR_CHAR('0');
+				} else {
+					param_str = zval_try_get_string(tmp);
+				}
 				if (!param_str) {
 					_php_pgsql_free_params(params, num_params);
 					RETURN_THROWS();
@@ -3754,9 +3764,18 @@ PHP_FUNCTION(pg_send_query_params)
 			if (Z_TYPE_P(tmp) == IS_NULL) {
 				params[i] = NULL;
 			} else {
-				zend_string *tmp_str;
-				zend_string *str = zval_get_tmp_string(tmp, &tmp_str);
-
+				zend_string *str, *tmp_str;
+				/**
+				 * zval_get_tmp_string returns an empty zend_string
+				 * for false which is correct in general
+				 * but not adequate for bool values in the db
+				 */
+				if (Z_TYPE_P(tmp) == IS_FALSE) {
+					tmp_str = ZSTR_CHAR('0');
+					str = tmp_str;
+				} else {
+					str = zval_get_tmp_string(tmp, &tmp_str);
+				}
 				params[i] = estrndup(ZSTR_VAL(str), ZSTR_LEN(str));
 				zend_tmp_string_release(tmp_str);
 			}

ext/pgsql/tests/33query_params_bool.phpt

@@ -0,0 +1,28 @@
+--TEST--
+PostgreSQL prepared queries with bool constants
+--SKIPIF--
+<?php
+include("skipif.inc");
+if (!function_exists('pg_prepare')) die('skip function pg_prepare() does not exist');
+?>
+--FILE--
+<?php
+
+include('config.inc');
+
+$db = pg_connect($conn_str);
+
+$version = pg_version($db);
+if ($version['protocol'] >= 3) {
+    $result = pg_query_params($db, "SELECT * FROM ".$table_name." WHERE num >= $1;", array(true));
+    // bug occurs with false as it turns out as empty.
+    $result = pg_query_params($db, "SELECT * FROM ".$table_name." WHERE num <> $1;", array(false));
+    pg_free_result($result);
+}
+pg_close($db);
+
+echo "OK";
+?>
+--EXPECT--
+OK
+