[mysqli] Simply if -> RETURN_TRUE/FALSE with RETURN_BOOL() (GH-21149)

arshidkv12 · web-flow · commit f0d321e9477c · 2026-02-06T10:07:54.000+01:00
diff --git a/ext/mysqli/mysqli_api.c b/ext/mysqli/mysqli_api.c
@@ -1410,10 +1410,7 @@ PHP_FUNCTION(mysqli_stmt_send_long_data)
 		RETURN_THROWS();
 	}
 
-	if (mysql_stmt_send_long_data(stmt->stmt, param_nr, data, data_len)) {
-		RETURN_FALSE;
-	}
-	RETURN_TRUE;
+	RETURN_BOOL(!mysql_stmt_send_long_data(stmt->stmt, param_nr, data, data_len));
 }
 /* }}} */
 
@@ -1552,10 +1549,7 @@ PHP_FUNCTION(mysqli_stmt_reset)
 
 	MYSQLI_FETCH_RESOURCE_STMT(stmt, mysql_stmt, MYSQLI_STATUS_VALID);
 
-	if (mysql_stmt_reset(stmt->stmt)) {
-		RETURN_FALSE;
-	}
-	RETURN_TRUE;
+	RETURN_BOOL(!mysql_stmt_reset(stmt->stmt));
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -1410,10 +1410,7 @@ PHP_FUNCTION(mysqli_stmt_send_long_data)`
`1410`	`1410`	`RETURN_THROWS();`
`1411`	`1411`	`}`
`1412`	`1412`
`1413`		`- if (mysql_stmt_send_long_data(stmt->stmt, param_nr, data, data_len)) {`
`1414`		`- RETURN_FALSE;`
`1415`		`- }`
`1416`		`- RETURN_TRUE;`
	`1413`	`+ RETURN_BOOL(!mysql_stmt_send_long_data(stmt->stmt, param_nr, data, data_len));`
`1417`	`1414`	`}`
`1418`	`1415`	`/* }}} */`
`1419`	`1416`
`@@ -1552,10 +1549,7 @@ PHP_FUNCTION(mysqli_stmt_reset)`
`1552`	`1549`
`1553`	`1550`	`MYSQLI_FETCH_RESOURCE_STMT(stmt, mysql_stmt, MYSQLI_STATUS_VALID);`
`1554`	`1551`
`1555`		`- if (mysql_stmt_reset(stmt->stmt)) {`
`1556`		`- RETURN_FALSE;`
`1557`		`- }`
`1558`		`- RETURN_TRUE;`
	`1552`	`+ RETURN_BOOL(!mysql_stmt_reset(stmt->stmt));`
`1559`	`1553`	`}`
`1560`	`1554`	`/* }}} */`
`1561`	`1555`