ext/intl: Guard Spoofchecker restriction-level APIs at ICU 53

PHP 8.4.22 fails to build the intl extension against ICU 50.x. The change that
landed for GH-22055 removed the U_ICU_VERSION_MAJOR_NUM >= 58 guards around the
Spoofchecker restriction-level constants (ASCII, HIGHLY_RESTRICTIVE,
MODERATELY_RESTRICTIVE, MINIMALLY_RESTRICTIVE, UNRESTRICTIVE,
SINGLE_SCRIPT_RESTRICTIVE and MIXED_NUMBERS) and the setRestrictionLevel()
method, so the extension references those ICU symbols unconditionally. That is
fine on master and PHP-8.5, where build/php.m4 requires icu-uc >= 57.1, but on
PHP-8.4 the minimum is still icu-uc >= 50.1 and the symbols do not exist that far
back. On a system with ICU 50.x such as Amazon Linux 2 (ICU 50.2, which
satisfies the 50.1 requirement) configure succeeds and the compile then fails
with USPOOF_ASCII, the other restriction-level constants and URestrictionLevel
undeclared.

The correct floor is ICU 53: these symbols, URestrictionLevel and
uspoof_setRestrictionLevel() exist since ICU 51, except
USPOOF_SINGLE_SCRIPT_RESTRICTIVE which was added in ICU 53 and is referenced both
as a constant and in the setRestrictionLevel() body. Guarding at ICU 53 restores
the build on every ICU version PHP-8.4 supports while keeping the
restriction-level API exposed on ICU 53 and later, preserving the intent of
GH-22055 (the previous >= 58 guard was too strict and hid the API on ICU 57.x).

Author: GrahamCampbell

ext/intl/spoofchecker/spoofchecker.stub.php

@@ -19,6 +19,7 @@ class Spoofchecker
     public const int INVISIBLE = UNKNOWN;
     /** @cvalue USPOOF_CHAR_LIMIT */
     public const int CHAR_LIMIT = UNKNOWN;
+#if U_ICU_VERSION_MAJOR_NUM >= 53
     /** @cvalue USPOOF_ASCII */
     public const int ASCII = UNKNOWN;
     /** @cvalue USPOOF_HIGHLY_RESTRICTIVE */
@@ -33,6 +34,7 @@ class Spoofchecker
     public const int SINGLE_SCRIPT_RESTRICTIVE = UNKNOWN;
     /** @cvalue USPOOF_MIXED_NUMBERS */
     public const int MIXED_NUMBERS = UNKNOWN;
+#endif
 #if U_ICU_VERSION_MAJOR_NUM >= 62
     /** @cvalue USPOOF_HIDDEN_OVERLAY */
     public const int HIDDEN_OVERLAY = UNKNOWN;
@@ -69,7 +71,9 @@ public function setAllowedLocales(string $locales): void {}
     /** @tentative-return-type */
     public function setChecks(int $checks): void {}
 
+#if U_ICU_VERSION_MAJOR_NUM >= 53
     /** @tentative-return-type */
     public function setRestrictionLevel(int $level): void {}
+#endif
     public function setAllowedChars(string $pattern, int $patternOptions = 0): void {}
 }

ext/intl/spoofchecker/spoofchecker_arginfo.h

@@ -135,6 +135,7 @@ PHP_METHOD(Spoofchecker, setChecks)
 }
 /* }}} */
 
+#if U_ICU_VERSION_MAJOR_NUM >= 53
 /* TODO Document this method on PHP.net */
 /* {{{ Set the loosest restriction level allowed for strings. */
 PHP_METHOD(Spoofchecker, setRestrictionLevel)
@@ -163,6 +164,7 @@ PHP_METHOD(Spoofchecker, setRestrictionLevel)
 	uspoof_setRestrictionLevel(co->uspoof, (URestrictionLevel)level);
 }
 /* }}} */
+#endif
 
 PHP_METHOD(Spoofchecker, setAllowedChars)
 {

ext/intl/spoofchecker/spoofchecker_main.c

@@ -4,6 +4,12 @@ spoofchecker with restriction level
 intl
 --SKIPIF--
 <?php if(!class_exists("Spoofchecker")) print 'skip'; ?>
+<?php
+    $r = new ReflectionClass("SpoofChecker");
+    if (false === $r->getConstant("SINGLE_SCRIPT_RESTRICTIVE")) {
+        die("skip Incompatible ICU version");
+    }
+?>
 --FILE--
 <?php
 

ext/intl/tests/spoofchecker_007.phpt

@@ -4,6 +4,12 @@ Spoofchecker exposes restriction-level APIs on all supported ICU versions
 intl
 --SKIPIF--
 <?php if (!class_exists("Spoofchecker")) print 'skip'; ?>
+<?php
+    $r = new ReflectionClass("Spoofchecker");
+    if (false === $r->getConstant("SINGLE_SCRIPT_RESTRICTIVE")) {
+        die("skip Incompatible ICU version");
+    }
+?>
 --FILE--
 <?php
 $r = new ReflectionClass("Spoofchecker");

ext/intl/tests/spoofchecker_supported_icu57_apis.phpt

@@ -5,6 +5,8 @@ intl
 --SKIPIF--
 <?php
 if (!class_exists("Spoofchecker")) print 'skip';
+
+if (!method_exists(new Spoofchecker(), 'setRestrictionLevel')) print 'skip ICU version < 53';
 ?>
 --FILE--
 <?php