Fix missing error propagation in openssl_x509_export_to_file()

ndossche · ndossche · commit fd6127070d3f · 2026-03-05T13:27:13.000+01:00
The file writes can have failed, but this error isn't visible for the
application, fix it by propagating the error properly.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -1569,9 +1569,11 @@ PHP_FUNCTION(openssl_x509_export_to_file)
 	if (bio_out) {
 		if (!notext && !X509_print(bio_out, cert)) {
 			php_openssl_store_errors();
+			goto exit_cleanup_bio;
 		}
 		if (!PEM_write_bio_X509(bio_out, cert)) {
 			php_openssl_store_errors();
+			goto exit_cleanup_bio;
 		}
 
 		RETVAL_TRUE;
@@ -1580,6 +1582,7 @@ PHP_FUNCTION(openssl_x509_export_to_file)
 		php_error_docref(NULL, E_WARNING, "Error opening file %s", file_path);
 	}
 
+exit_cleanup_bio:
 	if (!BIO_free(bio_out)) {
 		php_openssl_store_errors();
 	}

Original file line number	Diff line number	Diff line change
`@@ -1569,9 +1569,11 @@ PHP_FUNCTION(openssl_x509_export_to_file)`
`1569`	`1569`	`if (bio_out) {`
`1570`	`1570`	`if (!notext && !X509_print(bio_out, cert)) {`
`1571`	`1571`	`php_openssl_store_errors();`
	`1572`	`+ goto exit_cleanup_bio;`
`1572`	`1573`	`}`
`1573`	`1574`	`if (!PEM_write_bio_X509(bio_out, cert)) {`
`1574`	`1575`	`php_openssl_store_errors();`
	`1576`	`+ goto exit_cleanup_bio;`
`1575`	`1577`	`}`
`1576`	`1578`
`1577`	`1579`	`RETVAL_TRUE;`
`@@ -1580,6 +1582,7 @@ PHP_FUNCTION(openssl_x509_export_to_file)`
`1580`	`1582`	`php_error_docref(NULL, E_WARNING, "Error opening file %s", file_path);`
`1581`	`1583`	`}`
`1582`	`1584`
	`1585`	`+exit_cleanup_bio:`
`1583`	`1586`	`if (!BIO_free(bio_out)) {`
`1584`	`1587`	`php_openssl_store_errors();`
`1585`	`1588`	`}`