Remove language for recreating tags (which is dangerous), and using patch levels (which isn't standard practise).#19367
Open
derickr wants to merge 1 commit intophp:masterfrom
Open
Remove language for recreating tags (which is dangerous), and using patch levels (which isn't standard practise).#19367derickr wants to merge 1 commit intophp:masterfrom
derickr wants to merge 1 commit intophp:masterfrom
Conversation
…atch levels (which isn't standard practise).
Member
|
@php/release-managers should review this and or merge this if appropriate. |
NattyNarwhal
approved these changes
Apr 6, 2026
edorian
approved these changes
Apr 6, 2026
Member
edorian
left a comment
edorian
left a comment
There was a problem hiding this comment.
Great! Removing the docs for a -pl release makes sense to me and I agree we shouldn't do those (most tooling doesn't take them into account anyway as far as I'm aware).
Is there anything that needs to be done to mark a Tag/Release as broken anywhere?
Comment on lines
+835
to
+836
| might happen if the tarballs have a corrupted file, for example, or when there | ||
| is a build error. |
Member
There was a problem hiding this comment.
Optional suggestion for rewording:
In rare cases, a release may need to be redone, for example if a tarball contains a corrupted file or a build issue is discovered.
Comment on lines
+842
to
+844
| You *must not* delete and recreate a pushed tag. Instead, you need to go | ||
| through the full packaging process again, as described above, whilst increasing | ||
| the version number. This is unfortunate, but published tags must be immutable. |
Member
There was a problem hiding this comment.
Suggested change
| You *must not* delete and recreate a pushed tag. Instead, you need to go | |
| through the full packaging process again, as described above, whilst increasing | |
| the version number. This is unfortunate, but published tags must be immutable. | |
| You *must not* delete and recreate a pushed tag. Instead, | |
| repeat the full packaging process described above and publish the | |
| next regular version number. This is unfortunate, but published tags | |
| must be immutable. |
Optional suggestion, avoiding the very BE "whilst"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.