XP_SOCKET XP_SSL (Socket stream modules): Incorrect condition for Win32/Win64

[EdmondDantes]

php-src/main/streams/xp_socket.c

Line 880 in 49fdf49

if (clisock >= 0) {

	if (clisock >= 0) {

This condition will never be true on Windows, because the type php_socket_t is UINT_PTR, and the value -1 will always be greater than zero.

Correct fix: introduce the INVALID_SOCKET constant for both platforms.

⚠️ This issue causes timeout warnings not to be displayed on Windows.

[EdmondDantes]

• Possible fix: master...true-async:php-src:bug-windows-invalid-socket-check

[bukka]

Good that you noticed this master regression that was introduced in #19106 . It's actually not an issue on lower branches and xp_ssl where int was used but that master refactoring changed type. The behavior wasn't really correct on lower branches anyway as it was relying on implementation defined behavior (changing signedness when casting unsigned to signed) so I created a fix for that in #19881.

Btw. there is already SOCK_ERR for what you described...

[bukka]

Sorry linked the wrong issue before (edited now): Fix is in #19881