Skip to content

Handle errors in mysqli_begin_transaction#20203

Closed
kamil-tekiela wants to merge 2 commits intophp:PHP-8.3from
kamil-tekiela:Fix-error-handling-in-mysqli_begin_transaction
Closed

Handle errors in mysqli_begin_transaction#20203
kamil-tekiela wants to merge 2 commits intophp:PHP-8.3from
kamil-tekiela:Fix-error-handling-in-mysqli_begin_transaction

Conversation

@kamil-tekiela
Copy link
Copy Markdown
Member

No description provided.

@kamil-tekiela kamil-tekiela force-pushed the Fix-error-handling-in-mysqli_begin_transaction branch from a94443a to 84a6e67 Compare October 17, 2025 14:06
@jorgsowa
Copy link
Copy Markdown
Contributor

Please don't use Squashed commit of the following: or similar as commit title. It's hard to track changes this way.

@kamil-tekiela
Copy link
Copy Markdown
Member Author

Please don't use Squashed commit of the following: or similar as commit title. It's hard to track changes this way.

I know, sorry. I only noticed after I pushed. I thought the branch name would be the commit name by default after squash.

@TimWolla
Copy link
Copy Markdown
Member

I just needed to bisect for this change, because it did not appear in the changelog. NEWS was not properly updated:

  • For PHP-8.3 it was added to 8.3.29 (which had already been branched at that point).
  • For PHP-8.4 it was added to 8.4.16 (which had already been branched at that point).
  • For PHP-8.5 it was added to 8.5.1 (which had already been branched at that point).

And I was also confused by the NEWS merges, since it appears that the merge from 8.3 to 8.4 dropped the NEWS item for a1912e3 and 159ef14, but from what I see those NEWS entry were not properly added to 8.4 and higher in the first place. /cc @ndossche


Since this change has a non-trivial chance making broken code more visible (by suddenly throwing exceptions instead of silently failing), we should make sure that it is properly listed in all changelogs.

/cc @php/release-managers-83 @php/release-managers-84 @php/release-managers-85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants