Fix GH-20674 mb_decode_mimeheader does not handle separator#20677
Fix GH-20674 mb_decode_mimeheader does not handle separator#20677youkidearitai wants to merge 6 commits intophp:PHP-8.3from
Conversation
`?= =?` is skipped if long term, so skip space character.
|
@youkidearitai, thanks very much for working on this issue! My understanding of RFC 2047 was that when performing encoding of a non-ASCII string into "encoded words", the encoder should put CR + LF + space (in that order) between each encoded word. However, the reporter of GH 20674 says that I also just checked what Python's |
|
Looks great. Many thanks to @youkidearitai |
See: https://www.ietf.org/rfc/rfc2047#section-8 And fix (=?ISO-8859-1?Q?a?= =?ISO-8859-2?Q?_b?=) as (a b).
|
I found a bug, so fix it. Last result is |
Awesome! Thank you!! I noticed that RFC 2047 contains 7 test cases in section 8, and you brought 6 of those test cases into the PHP test suite... could we use all 7 of them? |
|
@alexdowad Thank you! I got it. I deleted duplicate test cases. |
|
😅 Sorry that my comment maybe wasn't very clear. |
This reverts commit fdd4e84.
|
Thank you. I see. Added😊. (ありがとうございます、承知しました。追加しなおしますね😊) |
|
@youkidearitai Do you want to go ahead and merge this PR? |
|
@alexdowad Yes, I would like to merge this PR. |
Closes: #20674
In RFC2047
?= =?is skipped if long term, so skip space character.cc: @alexdowad