ext/spl: DirectoryIterator to support modern filesytems.#20705
Closed
devnexen wants to merge 1 commit intophp:masterfrom
Closed
ext/spl: DirectoryIterator to support modern filesytems.#20705devnexen wants to merge 1 commit intophp:masterfrom
devnexen wants to merge 1 commit intophp:masterfrom
Conversation
With filesystems with builtin large capacity such as ZFS, Btfrs, NTFS or even ext4 with large_dir feature enabled, an int to represent an entry index is falling short, thus risking overflows. A zend_long however should cover this need without increasing out internal data structure.
Member
Author
|
PR after discussing it with @Girgias. As she said, the change even fills the existing padding in the inner directory struct on 64 bits. |
Member
|
Makes sense. Could even be unsigned? |
Member
Author
|
in practice, there is no actual FS able to handle a number of directory entries remotely close to |
ndossche
approved these changes
Dec 14, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Checked all uses of u.dir.index and seems fine. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With filesystems with builtin large capacity such as ZFS, Btfrs, NTFS
or even ext4 with large_dir feature enabled, an int to represent an
entry index is falling short, thus risking overflows.
A zend_long however should cover this need without increasing out internal data structure.