Fix GH-9945: Reject shmop/sysvshm keys outside key_t range#22423
Merged
Conversation
Girgias
approved these changes
Jun 24, 2026
Girgias
left a comment
Member
There was a problem hiding this comment.
Ideally a better error message would be possible, but this is at least something :)
Member
Author
|
@Girgias Lets see if this message would be better :) |
Member
I don't think so, as end-users won't have any idea what that is. So keeping a generic message of out of range is probably better. |
Member
Author
|
Fair :) |
79494eb to
270ffa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now,
shmop_open()andshm_attach()acceptedzend_longkeys and passed them directly to SysV shared memory APIs, where they may be truncated tokey_t.Generally we should throw ValurErrors on those issues. Fixes #9945