Labeler: Add labeler glob patterns for CI#16915
Conversation
.github/labeler.yml
Outdated
| - any-glob-to-any-file: | ||
| - .circleci/* | ||
| - .github/actions/**/* | ||
| - .github/CODEOWNERS |
There was a problem hiding this comment.
If we consider this to be CI, we might as well consider anything in .github/ to be CI. The only exceptions I'm seeing right now are lsan-suppressions.txt and labeler.yml itself.
There was a problem hiding this comment.
I was trying to exclude ISSUE_TEMPLATE folder and potentially future files like funding, code of conduct, etc files that are merely templates.
There was a problem hiding this comment.
Hi @TimWolla I rebased this PR, and hoping to revive it. Could I request another review please? I changed the glob patterns to include .github/* directory entirely, with two exceptions for ISSUE_TEMPLATE and lsan-suppressions.txt.
|
Is this PR still being purused? |
We have a "Category: CI" label in GH issues and PRs, but there is no labeler rule to automatically mark PRs as such. This adds a labeler rule to automatically add the "Category: CI" label if the PR changes _any_ file in: - '.circleci/*' - '.github/*' If all the changes are within these files, it will _not_ be labelled. - '.github/ISSUE_TEMPLATE/*' - '.github/lsan-suppressions.txt'
|
@Girgias I had forgotten about it 🥲. We still do not have a I could use your review if possible, thank you. |
Not usually what I deal with, maybe @iluuu1994 is more suited for a review tho :) |
|
Was just about to merge, thanks! Small note: The indentation of the rest of the doc is weird (last level only has 2 spaces). Would be nice to fix that. |
Fixes mixed indentation from the previous PR GH-16915.
|
Thank you @iluuu1994, I'm sorry I just realized after merging 🥲. I also just pushed a fix, fixing the mixed indentation. |
4 participants
We have a "Category: CI" label in GH issues and PRs, but there is no labeler rule to automatically mark PRs as such.
This adds a labeler rule to automatically add the "Category: CI" label if the PR changes any file in:
-
.circleci/*-
.github/*If all the changes are within these files, it will not be labelled.
-
.github/ISSUE_TEMPLATE/*-
.github/lsan-suppressions.txt