Fix GH-18617: socket_import_file_descriptor return check.#18618
Closed
devnexen wants to merge 2 commits into
Closed
Fix GH-18617: socket_import_file_descriptor return check.#18618devnexen wants to merge 2 commits into
devnexen wants to merge 2 commits into
Conversation
to_zval_read_fd_array() helper when retrieving the socket protocol did not check it.
ndossche
reviewed
May 21, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
I was under the impression that more would be needed, but it seems the existing code already continues if something went wrong anyway and changing that may impact BC.
Anyway, don't you need to free up elem ?
ndossche
approved these changes
May 22, 2025
Member
Author
|
Merged with c30bddc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_zval_read_fd_array() helper when retrieving the socket protocol did not check it.