ext/intl: using a bit more modern c++ memory management features.

[devnexen]

not always possible (e.g. PHP objects) but when scoped we can manage here to simplify memory managament starting with IntlDateFormat.

[ndossche]

+1 on the idea. Some comments.

[ndossche]

I believe it's not necessary to value-initialize these unique_ptrs.

[devnexen]

yes true

[ndossche]

Can't you use make_unique here instead of unique_ptr+new ?

[devnexen]

I wish but isn't it C++14 minimum ?

[ndossche]

Ah right, and it's the ICU version that decides between C++11/C++17... Nvm then ;)

[SjonHortensius]

this change appears to be the reason I can no longer compile master:

ext/intl/dateformat/dateformat_format_object.cpp: In function ‘void zif_datefmt_format_object(zend_execute_data*, zval*)’:
ext/intl/dateformat/dateformat_format_object.cpp:73:7: error: ‘unique_ptr’ is not a member of ‘std’
  std::unique_ptr<TimeZone> timeZone;
       ^~~~~~~~~~
ext/intl/dateformat/dateformat_format_object.cpp:73:7: note: ‘std::unique_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
ext/intl/dateformat/dateformat_format_object.cpp:32:1:

does this change require an update of my dependencies or build scripts?

[devnexen]

Let me look at it, what is your compiler ? gcc or clang and version. ./configure options.

[devnexen]

@SjonHortensius let me know if the PR works for you cheers.