ext/phar: Minor refactorings#20162
Merged
Merged
Conversation
Girgias
force-pushed
the
phar-zend-result
branch
from
ecc05ca to
98a0e48
Compare
ndossche
reviewed
Oct 14, 2025
| zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0, | ||
| "Invalid argument, extraction path must be non-zero length"); | ||
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| if (pathto_len >= MAXPATHLEN) { | ||
| char *tmp = estrndup(pathto, 50); | ||
| if (ZSTR_LEN(path_to) >= MAXPATHLEN) { |
Member
There was a problem hiding this comment.
Note to self: this error branch can avoid allocation
Rather than casting to int
This saves 16 bytes
This saves 8 bytes by going from 152 to 144 bytes
This saves 16 bytes by going from 320 to 304 bytes
…nd checking for NULL Especially as the ptr is never used afterwards
Girgias
force-pushed
the
phar-zend-result
branch
from
98a0e48 to
7d8d934
Compare
ndossche
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls various changes out of #19356 and expanded on them.