Skip to content

Reorganize ext/uri tests - equivalence #20391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kocsismate merged 7 commits into from
Jan 13, 2026
Merged

Reorganize ext/uri tests - equivalence #20391

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
22fb6bc
Reorganize ext/uri tests - equivalence
kocsismate Nov 4, 2025
b4099c1
Adjust tests according to cod review
kocsismate Nov 5, 2025
034b481
Remove unneessary test
kocsismate Nov 19, 2025
4588860
Clean up tests and test names
kocsismate Jan 2, 2026
b5256e7
Fix test assertion
kocsismate Jan 2, 2026
8b3c01f
Address review comments
kocsismate Jan 8, 2026
58be97a
Same path
kocsismate Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions ext/uri/tests/036.phpt
View file
Open in desktop

This file was deleted.

15 changes: 15 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_false_host.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns false - host is different
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("https://user:info@192.168.0.1:443/foo/bar?abc=123&def=ghi#hashmark");

var_dump($uri1->equals($uri2));
var_dump($uri2->equals($uri1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_false_path.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns false - path is different
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar/baz?abc=123&def=ghi#hashmark");

var_dump($uri1->equals($uri2));
var_dump($uri2->equals($uri1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_false_port.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns false - port is different
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:442/foo/bar?abc=123&def=ghi#hashmark");

var_dump($uri1->equals($uri2));
var_dump($uri2->equals($uri1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_false_query.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns false - query is different
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123#hashmark");

var_dump($uri1->equals($uri2));
var_dump($uri2->equals($uri1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_false_query2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns false - query differs in casing
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?ABC=123&def=ghi#hashmark");

var_dump($uri1->equals($uri2));
var_dump($uri2->equals($uri1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_false_scheme.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns false - scheme is different
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("http://user@example.com:443/foo/bar/baz?abc=123&def=ghi#hashmark");
Comment thread
TimWolla marked this conversation as resolved.
Outdated

var_dump($uri1->equals($uri2));
var_dump($uri2->equals($uri1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_false_userinfo.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns false - userinfo is different
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("https://user@example.com:443/foo/bar?abc=123&def=ghi#hashmark");

var_dump($uri1->equals($uri2));
var_dump($uri2->equals($uri1));

?>
--EXPECT--
bool(false)
bool(false)
20 changes: 20 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_fragment_different.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - different fragment - include fragment variation
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hash");

var_dump($uri1->equals($uri2, Uri\UriComparisonMode::IncludeFragment));
var_dump($uri2->equals($uri1, Uri\UriComparisonMode::IncludeFragment));

var_dump($uri1->equals($uri2, Uri\UriComparisonMode::ExcludeFragment));
var_dump($uri2->equals($uri1, Uri\UriComparisonMode::ExcludeFragment));

?>
--EXPECT--
bool(false)
bool(false)
bool(true)
bool(true)
20 changes: 20 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_true_identical.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns true - identical URIs
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");

var_dump($uri1->equals($uri2, Uri\UriComparisonMode::IncludeFragment));
var_dump($uri2->equals($uri1, Uri\UriComparisonMode::IncludeFragment));

var_dump($uri1->equals($uri2, Uri\UriComparisonMode::ExcludeFragment));
var_dump($uri2->equals($uri1, Uri\UriComparisonMode::ExcludeFragment));

?>
--EXPECT--
bool(true)
bool(true)
bool(true)
bool(true)
15 changes: 15 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_true_normalization1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns true - after multiple normalization steps
--FILE--
<?php

$uri1 = Uri\Rfc3986\Uri::parse("https://user:info@example%2ecom:443/foo/bar?abc=123&def=ghi#hashmark");
$uri2 = Uri\Rfc3986\Uri::parse("HTTPS://user:info@EXAMPLE.COM:0443/../foo/b%61r?abc=123&def=ghi#hashmark");

var_dump($uri1->equals($uri2));
var_dump($uri2->equals($uri1));

?>
--EXPECT--
bool(true)
bool(true)
15 changes: 15 additions & 0 deletions ext/uri/tests/rfc3986/equivalence/equals_true_normalization2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\Rfc3986\Uri equivalence - returns true - after IPv6 normalization
--FILE--
<?php

$uri1 = new Uri\Rfc3986\Uri("https://[2001:0db8:0001:0000:0000:0ab9:C0A8:0102]");
$uri2 = new Uri\Rfc3986\Uri("https://[2001:DB8:1::AB9:C0A8:102]");

var_dump($uri1->equals($uri2));
var_dump($uri2->equals($uri1));

?>
--EXPECT--
bool(true)
bool(true)
15 changes: 15 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_false_host.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\WhatWg\Url equivalence - returns false - host is different
--FILE--
<?php

$url1 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$url2 = Uri\WhatWg\Url::parse("https://user:pass@192.168.0.1:443/foo/bar?abc=123&def=ghi#hashmark");

var_dump($url1->equals($url2));
var_dump($url2->equals($url1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_false_password.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\WhatWg\Url equivalence - returns false - password is different
--FILE--
<?php

$url1 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$url2 = Uri\WhatWg\Url::parse("https://user:@example.com:443/foo/bar?abc=123&def=ghi#hashmark");

var_dump($url1->equals($url2));
var_dump($url2->equals($url1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_false_path.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\WhatWg\Url equivalence - returns false - path is different
--FILE--
<?php

$url1 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$url2 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar/baz?abc=123&def=ghi#hashmark");

var_dump($url1->equals($url2));
var_dump($url2->equals($url1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_false_path_percent_encoded.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\WhatWg\Url equivalence - returns false - path is not percent-decoded during normalization
--FILE--
<?php

$url1 = new Uri\WhatWg\Url("https://example.com/foo/bar");
$url2 = new Uri\WhatWg\Url("https://example.com/foo/b%61r");

var_dump($url1->equals($url2));
var_dump($url2->equals($url1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_false_port.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\WhatWg\Url equivalence - returns false - port is different
--FILE--
<?php

$url1 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$url2 = Uri\WhatWg\Url::parse("https://user:pass@example.com:442/foo/bar?abc=123&def=ghi#hashmark");

var_dump($url1->equals($url2));
var_dump($url2->equals($url1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_false_query.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\WhatWg\Url equivalence - returns false - query is different
--FILE--
<?php

$url1 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$url2 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar?abc=123#hashmark");

var_dump($url1->equals($url2));
var_dump($url2->equals($url1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_false_query2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\WhatWg\Url equivalence - returns false - query differs in casing
--FILE--
<?php

$url1 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$url2 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar?ABC=123&def=ghi#hashmark");

var_dump($url1->equals($url2));
var_dump($url2->equals($url1));

?>
--EXPECT--
bool(false)
bool(false)
15 changes: 15 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_false_user.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Test Uri\WhatWg\Url equivalence - returns false - user is different
--FILE--
<?php

$url1 = Uri\WhatWg\Url::parse("https://user:pass@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$url2 = Uri\WhatWg\Url::parse("http://usr:pass@example.com:443/foo/bar/baz?abc=123&def=ghi#hashmark");
Comment thread
TimWolla marked this conversation as resolved.
Outdated

var_dump($url1->equals($url2));
var_dump($url2->equals($url1));

?>
--EXPECT--
bool(false)
bool(false)
20 changes: 20 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_fragment_different.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--TEST--
Test Uri\WhatWg\Url equivalence - different fragment - include fragment variation
--FILE--
<?php

$url1 = Uri\WhatWg\Url::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$url2 = Uri\WhatWg\Url::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hash");

var_dump($url1->equals($url2, Uri\UriComparisonMode::IncludeFragment));
var_dump($url2->equals($url1, Uri\UriComparisonMode::IncludeFragment));

var_dump($url1->equals($url2, Uri\UriComparisonMode::ExcludeFragment));
var_dump($url2->equals($url1, Uri\UriComparisonMode::ExcludeFragment));

?>
--EXPECT--
bool(false)
bool(false)
bool(true)
bool(true)
20 changes: 20 additions & 0 deletions ext/uri/tests/whatwg/equivalence/equals_true_identical.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--TEST--
Test Uri\WhatWg\Url equivalence - returns true - identical URIs
--FILE--
<?php

$url1 = Uri\WhatWg\Url::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");
$url2 = Uri\WhatWg\Url::parse("https://user:info@example.com:443/foo/bar?abc=123&def=ghi#hashmark");

var_dump($url1->equals($url2, Uri\UriComparisonMode::IncludeFragment));
var_dump($url2->equals($url1, Uri\UriComparisonMode::IncludeFragment));

var_dump($url1->equals($url2, Uri\UriComparisonMode::ExcludeFragment));
var_dump($url2->equals($url1, Uri\UriComparisonMode::ExcludeFragment));

?>
--EXPECT--
bool(true)
bool(true)
bool(true)
bool(true)
Loading