Add "resource" to reserved classes#20778
Closed
jordikroon wants to merge 2 commits intophp:masterfrom
Closed
Conversation
The "resource" type keyword should be treated as a reserved class name to prevent it from being used as a class name, consistent with other built-in type keywords like "mixed", "object", and "iterable".
Add regression test to verify that class_alias() rejects 'resource' as a class alias name since it is a reserved keyword in PHP.
jordikroon
force-pushed
the
fix/reserved-classes
branch
from
820eb44 to
2b22344
Compare
Member
|
resource is not a type, nor a special variable |
Member
|
Right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since resource is a special variable, it should also be listed as a reserved class.
This is an improvement to the earlier additions of array and closure #16665