Fix OOB gzseek() causing assertion failure#20785
Closed
ndossche wants to merge 3 commits intophp:PHP-8.3from
Closed
Fix OOB gzseek() causing assertion failure#20785ndossche wants to merge 3 commits intophp:PHP-8.3from
ndossche wants to merge 3 commits intophp:PHP-8.3from
Conversation
devnexen
reviewed
Dec 26, 2025
| *newoffs = gzseek(self->gz_file, offset, whence); | ||
|
|
||
| return (*newoffs < 0) ? -1 : 0; | ||
| off_t new_offset = gzseek(self->gz_file, offset, whence); |
Member
There was a problem hiding this comment.
(tiny) nit: new_offset should be a z_off_t.
devnexen
approved these changes
Dec 26, 2025
Member
devnexen
left a comment
devnexen
left a comment
There was a problem hiding this comment.
makes sense. I m surprised no one reported it tough, seems pretty straightforward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.