Omit free for frameless calls returning non-RC types#20819
Closed
iluuu1994 wants to merge 1 commit intophp:masterfrom
Closed
Omit free for frameless calls returning non-RC types#20819iluuu1994 wants to merge 1 commit intophp:masterfrom
iluuu1994 wants to merge 1 commit intophp:masterfrom
Conversation
arnaud-lb
approved these changes
Jan 2, 2026
Member
arnaud-lb
left a comment
arnaud-lb
left a comment
There was a problem hiding this comment.
This looks right to me!
This already happens at optimization-time, so no benefit is expected. The aim is mostly to resolve the old TODO. Alternatively, we can just drop the comment.
I would slightly prefer just dropping the comment, as this adds redundancy, but I'm not opposed to this change.
Member
Author
|
@arnaud-lb Yeah that's fair, I just removed the comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This already happens at optimization-time, so no benefit is expected. The aim is mostly to resolve the old TODO. Alternatively, we can just drop the comment.