Always add PHP_MANDIR if exists#20825
Merged
kocsismate merged 1 commit intophp:masterfrom Jan 14, 2026
Merged
Conversation
jordikroon
force-pushed
the
fix/php-mandir
branch
from
4ba4243 to
ea614a0
Compare
Member
|
LGTM! Let's wait a few days or another approval before mergint it. |
petk
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change always adds the PHP_MANDIR constant if it exists. This should make it more consistent with other conditionals.
In practice it should not change anything, since PHP_MANDIR is not defined on windows.