ext/sodium: use correct constants and error messages#20852
Merged
jedisct1 merged 1 commit intophp:PHP-8.4from Jan 7, 2026
Merged
ext/sodium: use correct constants and error messages#20852jedisct1 merged 1 commit intophp:PHP-8.4from
jedisct1 merged 1 commit intophp:PHP-8.4from
Conversation
Fix copy-and-paste mistakes in the sodium extension. crypto_scalarmult_BYTES and crypto_scalarmult_ristretto255_BYTES have the same value, so behavior is unchanged.
TimWolla
approved these changes
Jan 7, 2026
jedisct1
added a commit
to dip-proto/php-src
that referenced
this pull request
Jan 7, 2026
* PHP-8.4: ext/sodium: use correct constants and error messages (php#20852)
jedisct1
added a commit
to dip-proto/php-src
that referenced
this pull request
Jan 7, 2026
* PHP-8.5: ext/sodium: use correct constants and error messages (php#20852)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix copy-and-paste mistakes in the sodium extension.
crypto_scalarmult_BYTESandcrypto_scalarmult_ristretto255_BYTEShave the same value, so behavior is unchanged.