gen_stub: Update the arginfo file timestamp when generation is skipped#20891
gen_stub: Update the arginfo file timestamp when generation is skipped#20891thg2k wants to merge 1 commit intophp:PHP-8.4from
Conversation
|
What's the right target for this? I have more similar fixes to the build process coming up. |
8.4 looks right. |
In case the script is started by the Makefile, the timestamp of the product needs to be updated even if no changes are needed, otherwise it will be started over and over without any effect.
|
@TimWolla You were right, the patch was bad because it touched the file even if gen_stub failed, blocking further attempts to regenerate the file. It would have needed a "&&" instead. I changed the PR to touch the file inside the gen_stub script instead of the Makefile. |
Thanks, can you please also adjust the PR title and description to match the new commit? |
thg2k
changed the title
Sure! Done. |
3 participants
In case the script is started by the Makefile, the timestamp of the product
needs to be updated even if no changes are needed, otherwise it will be
started over and over without any effect.