Fix GH-20871: Improve error message for invalid -d options

[khaledalam]

Description

Fixes #20871 by improving error messages for invalid -d command-line options.

Previously, when an invalid -d option was passed to PHP CLI, the error message reported "Unknown on line X". This was confusing for users who don't know about PHP's internal INI handling.

Changes

• Modified Zend/zend_ini_parser.y to detect CLI/FPM -d option parsing context
• When parsing -d options (filename is "Unknown" and unbuffered_errors is true), error messages now report "-d option on line 0" instead of "Unknown on line X"
• Added test case sapi/cli/tests/gh20871.phpt to verify the fix with multiple invalid syntax scenarios

[iluuu1994]

It would probably help even more if there was an indication that the parsing error happens for INI parsing, rather than parsing of the PHP code. For example, instead of "in Unknown" it could print "in INI command line parameter '-d'". Or maybe even the INI line itself.

[khaledalam]

It would probably help even more if there was an indication that the parsing error happens for INI parsing, rather than parsing of the PHP code. For example, instead of "in Unknown" it could print "in INI command line parameter '-d'". Or maybe even the INI line itself.

@iluuu1994 Thank you for the feedback! I've updated the message. The error message now clearly indicates this is INI parsing,

e.g. PHP: syntax error, unexpected '=' in INI command line parameter '-d'

[iluuu1994]

Probably better if this is also reviewed by somebody else. ^^ @bukka?

[iluuu1994]

You probably want to check if (ini_filename) instead. Side-note: The if (currently_parsed_filename) { is useless because zend_ini_scanner_get_filename() never returns NULL.

[iluuu1994]

Why does this check CG(ini_parser_unbuffered_errors)?

[khaledalam]

To distinguish CLI/FPM -d INI overrides from parse_ini_string(). in basic_functions.c it's called with unbuffered_errors = 0, while the other call sites pass 1.

[iluuu1994]

Can ini_filename be unset for any other reasons? E.g. when set in php-fpm.conf or php_value in Apache?

[khaledalam]

The unbuffered_errors check correctly identifies CLI/FPM command-line cases. For fpm conf and Apache php_value, I think those use zend_parse_ini_file() which sets ini_filename from the file handle.

[khaledalam]

Hi @bukka, can you review this PR please.

[jorgsowa]

PHP: syntax error, unexpected '=' in INI command line parameter '-d'

1. There is double space. Could be fixed as well when you touch the code.
2. I'm not sure about this naming. It's still not very clear what is INI command here. What do you think about PHP: syntax error, invalid -d parameter. Unexpected '=' in INI value or PHP: syntax error, malformed INI override passed via '-d'.

Or modified proposed version PHP: syntax error, unexpected '=' in parameter '-d'