ext/sqlite3: Sqlite3::openBlob() code path simplification.#20969
Merged
devnexen merged 2 commits intophp:masterfrom Jan 20, 2026
Merged
ext/sqlite3: Sqlite3::openBlob() code path simplification.#20969devnexen merged 2 commits intophp:masterfrom
devnexen merged 2 commits intophp:masterfrom
Conversation
since the stream is opened in non persistent mode, the failure code path is dead (so are the missing leaks fixes).
Girgias
reviewed
Jan 19, 2026
Comment on lines
-1274
to
-1279
|
|
||
| if (stream) { | ||
| php_stream_to_zval(stream, return_value); | ||
| } else { | ||
| RETURN_FALSE; | ||
| } |
Girgias
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since the stream is opened in non persistent mode, the failure code path is dead (so are the missing leaks fixes).