Remove unreachable code after zend_error_noreturn calls.

[khaledalam]

Description

zend_error_noreturn() never returns (marked with ZEND_NORETURN), so any code following it is dead code that can never be executed.

[iluuu1994]

No strong opinion, some compilers do not understand ZEND_NORETURN and thus may fail with strange errors in some cases. Also, you missed a few similar instances. This regex may help. zend_error_noreturn\([^)]*\);\n\s*[^}\s]

[khaledalam]

No strong opinion, some compilers do not understand ZEND_NORETURN and thus may fail with strange errors in some cases. Also, you missed a few similar instances. This regex may help. zend_error_noreturn\([^)]*\);\n\s*[^}\s]

Thank @iluuu1994 for the feedback.

I noticed the codebase already has instances where zend_error_noreturn() is the last statement in a non-void function without a return (e.g., zend_mark_internal_attribute in zend_attributes.c). If compilers without ZEND_NORETURN support were a real concern, these would already cause warnings/errors. This PR follows the same existing pattern.

Regarding the remaining instances from your regex, Would you prefer that I:

1. Remove the dead code from those places as well (consistent cleanup)?
2. Replace the dead code with ZEND_UNREACHABLE() instead?
3. Leave the PR as-is for now?

Happy to adjust based on your guidance.

[iluuu1994]

Fair enough. Please adjust the remaining cases then.

[dstogov]

That code was kept to avoid "warning: control reaches end of non-void function" on Windows.

[khaledalam]

That code was kept to avoid "warning: control reaches end of non-void function" on Windows.

Thanks @dstogov for the feedback, makes sense. I’m on macOS, so I didn’t hit that.

Is this MSVC C4715? I’d like to reproduce locally / confirm via CI

[iluuu1994]

@khaledalam Windows already runs in CI. I'm guessing Dmitry is referring to older versions of MSVC. IMO this change should be ok for master. If somebody complains it can always be reverted.

[dstogov]

@khaledalam Windows already runs in CI. I'm guessing Dmitry is referring to older versions of MSVC. IMO this change should be ok for master. If somebody complains it can always be reverted.

I see # define ZEND_NORETURN __declspec(noreturn) was added in PHP_7_0, but I remember we had compiler warnings.
Probably some MSVC version started to handle this attribute better.
Anyway, I don't care. Just pointed why these lines weren't deleted before.
Go forward.

[iluuu1994]

Thanks @khaledalam!

[khaledalam]

You are welcome 🙏 @iluuu1994