Fix crash in openssl_x509_parse() when i2s_ASN1_INTEGER() fails#21011
Closed
ndossche wants to merge 1 commit intophp:PHP-8.4from
Closed
Fix crash in openssl_x509_parse() when i2s_ASN1_INTEGER() fails#21011ndossche wants to merge 1 commit intophp:PHP-8.4from
ndossche wants to merge 1 commit intophp:PHP-8.4from
Conversation
The X509_NAME_oneline() function can return NULL, which will cause a crash when the string length is computed via add_assoc_string().
bukka
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The X509_NAME_oneline() function can return NULL,
which will cause a crash when the string length is computed via add_assoc_string().
This was found by a hybrid static-dynamic analyser that looks for inconsistent handling of error checks in bindings.