Merged
Conversation
When trying to build on LibreSSL, I encounter the following build
warning (this was observed on master, but applies to 8.4 too):
```
/work/php-src/ext/openssl/openssl.c: In function 'zif_openssl_x509_parse':
/work/php-src/ext/openssl/openssl.c:1101:22: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1101 | purp = X509_PURPOSE_get0(i);
| ^
/work/php-src/ext/openssl/openssl.c:1110:23: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1110 | pname = useshortnames ? X509_PURPOSE_get0_sname(purp) : X509_PURPOSE_get0_name(purp);
```
bukka
reviewed
Apr 3, 2026
Member
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
Looks good, I verified that it's X509_PURPOSE_get0_sname and X509_PURPOSE_get0_name both accept const on all supported version (1.1.1 included).
bukka
approved these changes
Apr 3, 2026
ndossche
added a commit
that referenced
this pull request
Apr 3, 2026
* PHP-8.4: Fix build warning on LibreSSL (#21050)
ndossche
added a commit
that referenced
this pull request
Apr 3, 2026
* PHP-8.5: Fix build warning on LibreSSL (#21050)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to build on LibreSSL, I encounter the following build warning (this was observed on master, but applies to 8.4 too):