Skip to content

ext/standard: validate mode is within 0..07777 #21152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arshidkv12 wants to merge 5 commits into from
+52 −0
Closed

ext/standard: validate mode is within 0..07777 #21152

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12d8be7
ext/standard: validate mode is within 0..07777
arshidkv12 Feb 6, 2026
ea473b7
ext/standard: validate mode is within 0..07777
arshidkv12 Feb 6, 2026
9e68bae
ext/stamdard: Fix mkdir() invalid mode error handling
arshidkv12 Feb 8, 2026
79a692a
ext invalid mode error handling
arshidkv12 Feb 9, 2026
093c720
ext invalid mode error handling
arshidkv12 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ext/standard/file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,6 +1087,11 @@ PHP_FUNCTION(mkdir)
Z_PARAM_RESOURCE_OR_NULL(zcontext)
ZEND_PARSE_PARAMETERS_END();

if (mode < 0 || (mode & ~07777)) {
Copy link
Copy Markdown
Member

@Girgias Girgias Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to provide a Zend API for this. As a lot of code does file permissions checks (including INI settings (or should at least))

Copy link
Copy Markdown
Contributor Author

@arshidkv12 arshidkv12 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve created a helper function zend_validate_file_permissions(). I think this can be used to validate permission masks for any filesystem-related operations. Please let me know if this approach makes sense.

zend_argument_value_error(2, "must be between 0 and 0o7777");
RETURN_THROWS();
}

context = php_stream_context_from_zval(zcontext, 0);

RETURN_BOOL(php_stream_mkdir(dir, (int)mode, (recursive ? PHP_STREAM_MKDIR_RECURSIVE : 0) | REPORT_ERRORS, context));
Expand Down
34 changes: 34 additions & 0 deletions ext/standard/tests/file/mkdir_invalid_mode.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
--TEST--
mkdir(): invalid mode
--FILE--
<?php
Copy link
Copy Markdown
Member

@devnexen devnexen Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add few more cases (e.g. -1)

Copy link
Copy Markdown
Contributor Author

@arshidkv12 arshidkv12 Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

$testCases = [
1000000, // way too large
-1, // negative
0o10000, // above 0o7777
0x1FFFF, // hex, still too large
12345, // arbitrary invalid
];

foreach ($testCases as $mode) {
try {
echo "Testing mode: $mode\n";
mkdir(__DIR__ . "/testdir_$mode", $mode);
} catch (ValueError $e) {
echo $e->getMessage(), PHP_EOL;
} catch (Exception $e) {
echo "Other exception: ", $e->getMessage(), PHP_EOL;
}
}
?>
--EXPECT--
Testing mode: 1000000
mkdir(): Argument #2 ($permissions) must be between 0 and 0o7777
Testing mode: -1
mkdir(): Argument #2 ($permissions) must be between 0 and 0o7777
Testing mode: 4096
mkdir(): Argument #2 ($permissions) must be between 0 and 0o7777
Testing mode: 131071
mkdir(): Argument #2 ($permissions) must be between 0 and 0o7777
Testing mode: 12345
mkdir(): Argument #2 ($permissions) must be between 0 and 0o7777
Loading