Skip to content

ext/mbstring: Replace RETVAL_TRUE/RETVAL_FALSE with RETVAL_BOOL #21276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexdowad merged 2 commits into from
Feb 26, 2026
Merged

ext/mbstring: Replace RETVAL_TRUE/RETVAL_FALSE with RETVAL_BOOL #21276

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2708c5a
ext/mbstring: Replace RETVAL_TRUE/RETVAL_FALSE with RETVAL_BOOL
arshidkv12 Feb 23, 2026
7c64369
ext/mbstring: Replace RETVAL_TRUE/RETVAL_FALSE with RETURN_BOOL
arshidkv12 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ext/mbstring/php_mbregex.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,11 +1303,7 @@ PHP_FUNCTION(mb_ereg_match)
/* match */
err = onig_match_with_param(re, (OnigUChar *)string, (OnigUChar *)(string + string_len), (OnigUChar *)string, NULL, 0, mp);
onig_free_match_param(mp);
if (err >= 0) {
RETVAL_TRUE;
} else {
RETVAL_FALSE;
}
RETVAL_BOOL(err >= 0);
Copy link
Copy Markdown
Member

@ndossche ndossche Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could even be RETURN_BOOL instead of RETVAL_BOOL

Copy link
Copy Markdown
Contributor

@alexdowad alexdowad Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True!

}
/* }}} */

Expand Down
Loading