Skip to content

openssl: Fix stack leak in php_openssl_load_all_certs_from_file()#21418

Closed
ndossche wants to merge 1 commit intophp:PHP-8.4from
ndossche:ossl-leak-x509-1
Closed

openssl: Fix stack leak in php_openssl_load_all_certs_from_file()#21418
ndossche wants to merge 1 commit intophp:PHP-8.4from
ndossche:ossl-leak-x509-1

Conversation

@ndossche
Copy link
Copy Markdown
Member

The previous code only freed the stack but not its contents. As reported by
4b9e80e#r179336568

The previous code only freed the stack but not its contents.
As reported by
php@4b9e80e#r179336568
@botovq
Copy link
Copy Markdown

botovq commented Mar 13, 2026

Here's an alternative fix: #21430

Copy link
Copy Markdown
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#21430 seems better as it also checks sk_X509_push

@ndossche
Copy link
Copy Markdown
Member Author

ndossche commented Apr 3, 2026

That's fair enough.

@ndossche ndossche closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants