Skip to content

Optimize JSON pretty print indentation performance #21474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iluuu1994 merged 11 commits into from
Mar 24, 2026
+3 −0
Merged

Optimize JSON pretty print indentation performance #21474

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1d40408
Update json_encoder.c
LamentXU123 Mar 20, 2026
a967ff1
Update UPGRADING
LamentXU123 Mar 20, 2026
9ac40b5
apply changes from reviews
LamentXU123 Mar 20, 2026
b6875ae
Update json_encoder.c
LamentXU123 Mar 21, 2026
c3ed1af
update threshold
LamentXU123 Mar 21, 2026
cd9192c
Update json_encoder.c
LamentXU123 Mar 21, 2026
6c5cd75
Revert "Update json_encoder.c"
LamentXU123 Mar 21, 2026
42b9ba6
lower the threshold through benchmark tests
LamentXU123 Mar 21, 2026
aea6397
Update json_encoder.c
LamentXU123 Mar 23, 2026
bdd8031
Update json_encoder.c
LamentXU123 Mar 23, 2026
f478681
use tabs
LamentXU123 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,8 @@ PHP 8.6 UPGRADE NOTES

- JSON:
. Improve performance of encoding arrays and objects.
. Improved performance of indentation generation in json_encode()
when using PHP_JSON_PRETTY_PRINT.

- Standard:
. Improved performance of array_fill_keys().
Expand Down
11 changes: 6 additions & 5 deletions ext/json/json_encoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,12 @@ static inline void php_json_pretty_print_char(smart_str *buf, int options, char

static inline void php_json_pretty_print_indent(smart_str *buf, int options, const php_json_encoder *encoder) /* {{{ */
{
if (options & PHP_JSON_PRETTY_PRINT) {
for (int i = 0; i < encoder->depth; ++i) {
smart_str_appendl(buf, " ", 4);
}
}
if (options & PHP_JSON_PRETTY_PRINT) {
smart_str_alloc(buf, encoder->depth * 4, 0);
for (int i = 0; i < encoder->depth; ++i) {
smart_str_appendl(buf, " ", 4);
}
}
}
/* }}} */

Expand Down
Loading