Skip to content

ext/standard: Use *_add instead of *_update for new keys in array_count_values #21530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iluuu1994 merged 3 commits into from
Mar 26, 2026
+2 −2
Merged

ext/standard: Use *_add instead of *_update for new keys in array_count_values #21530

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c277c03
Use *_add instead of *_update for new keys in array_count_values
arshidkv12 Mar 25, 2026
cacc12d
Use *_add instead of *_update for new keys in array_count_values
arshidkv12 Mar 26, 2026
6133455
ext/standard: zend_symtable_add_new
arshidkv12 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/standard/array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4493,15 +4493,15 @@ PHP_FUNCTION(array_count_values)
if ((tmp = zend_hash_index_find(Z_ARRVAL_P(return_value), Z_LVAL_P(entry))) == NULL) {
zval data;
ZVAL_LONG(&data, 1);
zend_hash_index_update(Z_ARRVAL_P(return_value), Z_LVAL_P(entry), &data);
zend_hash_index_add_new(Z_ARRVAL_P(return_value), Z_LVAL_P(entry), &data);
} else {
Z_LVAL_P(tmp)++;
}
} else if (Z_TYPE_P(entry) == IS_STRING) {
if ((tmp = zend_symtable_find(Z_ARRVAL_P(return_value), Z_STR_P(entry))) == NULL) {
zval data;
ZVAL_LONG(&data, 1);
zend_symtable_update(Z_ARRVAL_P(return_value), Z_STR_P(entry), &data);
zend_symtable_add(Z_ARRVAL_P(return_value), Z_STR_P(entry), &data);
} else {
Z_LVAL_P(tmp)++;
}
Expand Down
Loading