Skip to content

ext/xml: Use zend_hash_add() for missing array keys #21536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndossche merged 4 commits into from
Mar 26, 2026
Merged

ext/xml: Use zend_hash_add() for missing array keys #21536

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67fc067
ext/spl: Use zend_hash_add() for missing array keys
arshidkv12 Mar 26, 2026
bb5e2fa
ext/spl: Use zend_hash_add() for missing array keys
arshidkv12 Mar 26, 2026
e6d031c
ext/xml: Use zend_hash_lookup
arshidkv12 Mar 26, 2026
4286630
ext/xml: Use zend_hash_lookup
arshidkv12 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/xml/xml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ static void xml_add_to_info(xml_parser *parser, zend_string *name)
if ((element = zend_hash_find(arr, name)) == NULL) {
zval values;
array_init(&values);
element = zend_hash_update(arr, name, &values);
element = zend_hash_add(arr, name, &values);
}

add_next_index_long(element, parser->curtag);
Expand Down
Loading