-
Notifications
You must be signed in to change notification settings - Fork 8k
Optimize string allocation in uri_parser_rfc3986 when getting IPv6 hosts and url paths
#21550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+31
−13
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
992e5a7
Update uri_parser_rfc3986.c
LamentXU123 b8b4a7c
Apply code review
LamentXU123 ba2a1f5
use pointer arithmetic
LamentXU123 230bad7
Merge branch 'optimize-3' of https://github.com/LamentXU123/php-src i…
LamentXU123 84f7b2c
use ZVAL_NEW_STR instead of ZVAL_STR
LamentXU123 f7eeb4c
Update UPGRADING
LamentXU123 778712e
Merge branch 'optimize-3' of https://github.com/LamentXU123/php-src i…
LamentXU123 75dcdad
use zend_string_concat3
LamentXU123 9e763f3
Update ext/uri/uri_parser_rfc3986.c
LamentXU123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.