-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix enum case conflict in trait binding #21771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TimWolla
merged 6 commits into
php:PHP-8.4
from
prateekbhujel:prateekbhujel/fix-gh-21760-enum-trait-const-conflict
Apr 20, 2026
+39
−0
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cfc148f
Fix enum case conflict in trait binding
prateekbhujel 4d1f286
Use dedicated error for enum case conflict
prateekbhujel 90802ec
Adjust enum conflict wording
prateekbhujel ed9e563
Fix enum conflict format args
prateekbhujel b5ad5fd
Merge branch 'PHP-8.4' into prateekbhujel/fix-gh-21760-enum-trait-con…
TimWolla 5e23925
NEWS
TimWolla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --TEST-- | ||
| GH-21760 (Trait with class constant name conflict against enum case causes SEGV) | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| trait X { | ||
| public const Up = 1; | ||
| } | ||
|
|
||
| enum Direction { | ||
| use X; | ||
|
|
||
| case Up; | ||
| case Down; | ||
| } | ||
|
|
||
| ?> | ||
| --EXPECTF-- | ||
| Fatal error: Cannot use trait X, because constant Up conflicts with enum case Direction::Up in %s on line %d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.