Skip to content

/ext/standard: Check for empty string in linkinfo() #21793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LamentXU123 wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −8
Open

/ext/standard: Check for empty string in linkinfo() #21793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baccc0e
Update link.c
LamentXU123 Apr 18, 2026
ee2a1a6
switch to ValueError
LamentXU123 Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ext/standard/link.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@ PHP_FUNCTION(linkinfo)
Z_PARAM_PATH(link, link_len)
ZEND_PARSE_PARAMETERS_END();

// TODO Check for empty string
if (UNEXPECTED(link_len == 0)) {
zend_argument_must_not_be_empty_error(1);
RETURN_THROWS();
}

dirname = estrndup(link, link_len);
zend_dirname(dirname, link_len);

Expand Down
19 changes: 12 additions & 7 deletions ext/standard/tests/file/symlink_link_linkinfo_is_link_error1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,16 @@ var_dump( symlink($filename, false) ); // false as linkname
echo "\n*** Testing linkinfo() for error conditions ***\n";

//invalid arguments
var_dump( linkinfo('') ); // empty string as linkname
var_dump( linkinfo(false) ); // boolean false as linkname
try {
var_dump(linkinfo('')); // empty string as linkname
} catch (ValueError $e) {
echo $e->getMessage() . "\n";
}
try {
var_dump(linkinfo(false)); // boolean false as linkname
} catch (ValueError $e) {
echo $e->getMessage() . "\n";
}

echo "Done\n";
?>
Expand All @@ -54,9 +62,6 @@ bool(false)

*** Testing linkinfo() for error conditions ***

Warning: linkinfo(): %s in %s on line %d
int(-1)

Warning: linkinfo(): %s in %s on line %d
int(-1)
linkinfo(): Argument #1 ($path) must not be empty
linkinfo(): Argument #1 ($path) must not be empty
Done