Skip to content

ext/gmp: gmp_fact() reject values larger than unsigned long. #21794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devnexen wants to merge 1 commit into from
+29 −2
Closed

ext/gmp: gmp_fact() reject values larger than unsigned long. #21794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ext/gmp/gmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,8 +1092,10 @@ ZEND_FUNCTION(gmp_fact)
RETURN_THROWS();
}

// TODO: Check that we don't an int that is larger than an unsigned long?
// Could use mpz_fits_slong_p() if we revert to using mpz_get_si()
Copy link
Copy Markdown
Contributor

@LamentXU123 LamentXU123 Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment shouldn't be deleted (?)

Copy link
Copy Markdown
Member Author

@devnexen devnexen Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO is resolved by the new check right below — mpz_fits_ulong_p(gmpnum) is exactly what it was asking for. Keeping the comment would misleadingly suggest the
work is still pending. But wiating fairly Gina's opinion on it first :)

if (!mpz_fits_ulong_p(gmpnum)) {
zend_argument_value_error(1, "must be between 0 and %lu", ULONG_MAX);
RETURN_THROWS();
}

INIT_GMP_RETVAL(gmpnum_result);
mpz_fac_ui(gmpnum_result, mpz_get_ui(gmpnum));
Expand Down
25 changes: 25 additions & 0 deletions ext/gmp/tests/gmp_fact_overflow.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
--TEST--
gmp_fact() rejects values larger than unsigned long
--EXTENSIONS--
gmp
--FILE--
<?php

try {
var_dump(gmp_fact(gmp_pow(2, 100)));
} catch (\ValueError $e) {
echo $e->getMessage() . \PHP_EOL;
}

try {
var_dump(gmp_fact(gmp_init("18446744073709551616")));
} catch (\ValueError $e) {
echo $e->getMessage() . \PHP_EOL;
}

echo "Done\n";
?>
--EXPECTF--
gmp_fact(): Argument #1 ($num) must be between 0 and %d
gmp_fact(): Argument #1 ($num) must be between 0 and %d
Done
Loading