Skip to content

Modernize HTML markup in phpinfo output #22370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordikroon wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −9
Open

Modernize HTML markup in phpinfo output #22370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions ext/standard/info.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ static ZEND_COLD void php_print_gpcse_array(char *name, size_t name_length)
/* {{{ php_info_print_style */
PHPAPI ZEND_COLD void ZEND_COLD php_info_print_style(void)
{
php_info_printf("<style type=\"text/css\">\n");
php_info_printf("<style>\n");
php_info_print_css();
php_info_printf("</style>\n");
}
Expand Down Expand Up @@ -735,12 +735,13 @@ PHPAPI zend_string *php_get_uname(char mode)
/* {{{ php_print_info_htmlhead */
PHPAPI ZEND_COLD void php_print_info_htmlhead(void)
{
php_info_print("<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"DTD/xhtml1-transitional.dtd\">\n");
php_info_print("<html xmlns=\"http://www.w3.org/1999/xhtml\">");
php_info_print("<!DOCTYPE html>\n");
php_info_print("<html lang=\"en\">");
php_info_print("<head>\n");
php_info_print("<meta charset=\"utf-8\">");
php_info_print("<meta name=\"robots\" content=\"noindex,nofollow,noarchive\">");
php_info_print_style();
php_info_printf("<title>PHP %s - phpinfo()</title>", PHP_VERSION);
php_info_print("<meta name=\"ROBOTS\" content=\"NOINDEX,NOFOLLOW,NOARCHIVE\" />");
php_info_print("</head>\n");
php_info_print("<body><div class=\"center\">\n");
}
Expand Down Expand Up @@ -785,9 +786,9 @@ PHPAPI ZEND_COLD void php_print_info(int flag)

php_info_print("<a href=\"https://www.php.net/\"><img src=\"");
if (ta && (ta->tm_mon==3) && (ta->tm_mday==1)) {
php_info_print(PHP_EGG_LOGO_DATA_URI "\" alt=\"PHP logo\" /></a>");
php_info_print(PHP_EGG_LOGO_DATA_URI "\" alt=\"PHP logo\"></a>");
Comment on lines -788 to +789

@Girgias Girgias Jun 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with removing the the / to indicate an empty tag.

@jordikroon jordikroon Jun 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's better to not use the self closing variant. As "Self-closing tags () do not exist in HTML.".
This is acceptable by XHTML standards only.

https://developer.mozilla.org/en-US/docs/Glossary/Void_element#self-closing_tags

@Girgias Girgias Jun 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh, I do kinda hate the HTML spec at times.

} else {
php_info_print(PHP_LOGO_DATA_URI "\" alt=\"PHP logo\" /></a>");
php_info_print(PHP_LOGO_DATA_URI "\" alt=\"PHP logo\"></a>");
}
}

Expand Down Expand Up @@ -907,10 +908,10 @@ PHPAPI ZEND_COLD void php_print_info(int flag)
php_info_print_box_start(0);
if (!sapi_module.phpinfo_as_text) {
php_info_print("<a href=\"https://www.zend.com/\"><img src=\"");
php_info_print(ZEND_LOGO_DATA_URI "\" alt=\"Zend logo\" /></a>\n");
php_info_print(ZEND_LOGO_DATA_URI "\" alt=\"Zend logo\"></a>\n");
}
php_info_print("This program makes use of the Zend Scripting Language Engine:");
php_info_print(!sapi_module.phpinfo_as_text?"<br />":"\n");
php_info_print(!sapi_module.phpinfo_as_text?"<br>":"\n");
if (sapi_module.phpinfo_as_text) {
php_info_print(zend_version);
} else {
Expand Down Expand Up @@ -1148,7 +1149,7 @@ PHPAPI ZEND_COLD void php_info_print_box_end(void) /* {{{ */
PHPAPI ZEND_COLD void php_info_print_hr(void) /* {{{ */
{
if (!sapi_module.phpinfo_as_text) {
php_info_print("<hr />\n");
php_info_print("<hr>\n");
} else {
php_info_print("\n\n _______________________________________________________________________\n\n");
}
Expand Down
Loading